New Code! (I’m an idiot edition)
When I added immediate mail delivery to postoffice last month, I thought I'd tested the silly thing on a variety of machines. But, no, I didn't. I tested it on pell, which runs (as all good Linux boxes should) more-or-less SLS linux with a pure a.out userland (dunno what I'm going to do if I ever migrate the machine to a x86_64 platform, because at least as of Linux 2.6.9 a.out support has been broken there (with the traditional Linux "oh, nobody even uses a.out anyway" excuse that I've heard before) and I'm not planning to climb onto the Elf-style "we don't need backwards compatability! We're Open Source®™© and it's trivial™ to update 1500 software packages to the bleeding edge every time you turn around" until it's much closer to the time_t apocolypse.) and completely forgot to test it on newer systems that have a working flock() system call.
Valkai Elod, from temes.ro, sent me a patch today saying "um, this is where you broke postoffice in 1.3.8a" and I took a brief look only to discover that, yes, I hadn't tested 1.3.8a on any of my FreeBSD machines, because if I had I would have noticed that it was completely and utterly broken for lack of a two character prefix on a string.
So I put in a quick two-line fix and New Code! is available for people who like to have their MTA actually deliver mail.